Repository navigation
[Modules] Firewall Proposal PR (not main) - #1415
Merged
Alexander Sehr (AlexanderSehr) merged 6 commits intoMay 19, 2022
Merged
Alexander Sehr (AlexanderSehr) merged 6 commits into
Alexander Sehr (AlexanderSehr) merged 6 commits into
Conversation
* Added telemetry to AAD module & description to docs * Update to latest * Update to latest * Update to latest
Alexander Sehr (AlexanderSehr)
requested a review
from Jonathan Reynes (jontreynes)
May 19, 2022 14:05
Contributor
|
Here's working run of the code https://github.com/Azure/ResourceModules/actions/runs/2352598873 @MrMCake - I need to check the linter error - I was not getting this on my last PR |
Marius Storhaug (MariusStorhaug)
approved these changes
May 19, 2022
Marius Storhaug (MariusStorhaug)
left a comment
Contributor
There was a problem hiding this comment.
Guess Jonathan Reynes (@jontreynes) should approve too?
Alexander Sehr (AlexanderSehr)
merged commit May 19, 2022
8209feb
into
users/jontreynes/fwpipusecases
Contributor
yea, I just pushed a change to this branch to fix the linter natural language errors that you see here |
Contributor
|
ah wait looks like it was already merged - no worries I'll fix on my branch before merging to main |
Jonathan Reynes (jontreynes)
pushed a commit
that referenced
this pull request
May 23, 2022
* Fixed Inconsistent naming of NSGs IDs #1323 (#1406) * Added telemetry to AAD module & description to docs (#1393) * Added telemetry to AAD module & description to docs * Update to latest * Update to latest * Update to latest * Update to latest * Fixed several minor complains * Added condition Co-authored-by: prasanjeets <91326088+prasanjeets@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Proposed change of union